Create Regex benchmarks #11504
Create Regex benchmarks #11504
Conversation
GregoryTravis
requested review from
jdunkerley,
radeusgd,
AdRiley and
marthasharkey
as code owners
GregoryTravis
added
the
CI: No changelog needed
|
New PR since I did something unfixable to the old one's branch. |
| create = | ||
| faker = Faker.new | ||
| a_regex = Regex.compile "(\d)ab(\d)" | ||
| Data.Value (build_two_nums faker) (build_just_two_nums faker) (build_four_nums faker) a_regex (build_regexes faker) (build_replacers faker) (Regex.compile "(\d+)") (Regex.compile "(\d+)[a-z]+(\d+)") |
There was a problem hiding this comment.
Could this line be split into multiple ones? As
- since Move annotations into fields of Function and ConstructorDefinition #11374 it should be possible to:
Each argument in a type-constructor definition may be specified on its own (indented) line.
There was a problem hiding this comment.
This is a constructor invocation, not a definition -- should that also work? When I moved the arguments to multiple lines, I got syntax errors.
There was a problem hiding this comment.
from Standard.Base import all
type X
Y
a
b
main = X.Y
<| 1
<| 2
GregoryTravis
added
CI: Ready to merge
| <| (build_regexes faker) | ||
| <| (build_replacers faker) | ||
| <| (Regex.compile "(\d+)") | ||
| <| (Regex.compile "(\d+)[a-z]+(\d+)") |
There was a problem hiding this comment.
Och, óóó! That's way nicer! Honestly, up until yesterday I wasn't even aware we support such a nice syntax! I just confused this with @kazcw's multiline constructor definition and then wanted to find a way out without admitting I got confused...
There was a problem hiding this comment.
This would also work without the parens. In an operator block, each operator takes the rest of the line as its RHS.
There was a problem hiding this comment.
Removed parens.
jdunkerley
added
CI: Clean build required
jdunkerley
removed
the
CI: Keep up to date
GregoryTravis
added
the
CI: Ready to merge
…so into wip/gmt/6200-regex-benches-2
Includes benchmarks verifying regex and replacer compilation memoization.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.